Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/time sync warning #2469

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Enhance/time sync warning #2469

merged 6 commits into from
Aug 23, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Aug 22, 2024

closes https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/1857

To test:
A

  • login, then modify your system time to be out of sync by a couple of minutes.
  • Dex tab in sidebar should become disabled, and show a tooltip when hovering over
  • If on dex page, it should kick you to portfolio page

B

  • set your system time back to correct global time
  • Dex tab in sidebar should once again be active

cipig
cipig approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected
image

@smk762 smk762 merged commit eeb767c into dev Aug 23, 2024
6 checks passed
@smk762 smk762 deleted the enhance/time-sync-warning branch August 23, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@AndrewDelaney AndrewDelaney Awaiting requested review from AndrewDelaney

@ShantanuSharma9873 ShantanuSharma9873 Awaiting requested review from ShantanuSharma9873

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Device time sync check/warning
2 participants
@smk762 @cipig